Skip to content

Conversation

@triplef
Copy link
Contributor

@triplef triplef commented Mar 19, 2019

This fixes various "conflicting types for XXX" errors I get when building the project for Android after the recent libdispatch-1121 merge. The changes are not Android-specific though and probably result in warnings or errors on other platforms (depending on -Werror).

@triplef
Copy link
Contributor Author

triplef commented Mar 19, 2019

Thanks, I’ve updated the patch to only include the change for _dispatch_install_thread_detach_callback() in queue.c to align with queue_private.h.

@compnerd compnerd dismissed their stale review March 19, 2019 21:18

addressed

@triplef triplef changed the title Fixed various conflicting method signatures Fixed conflicting method signature for _dispatch_install_thread_detach_callback() Mar 20, 2019
@compnerd
Copy link
Member

@swift-ci please test

@compnerd
Copy link
Member

CC: @ktopley-apple

@ktopley-apple ktopley-apple merged commit f20349f into swiftlang:master Mar 20, 2019
rokhinip pushed a commit that referenced this pull request Nov 5, 2021
Fixed conflicting method signature for _dispatch_install_thread_detach_callback()

Signed-off-by: Kim Topley <ktopley@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants