Adding documentation to clarify the result of DispatchTime(uptimeNanoseconds: 0) #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please smoke test |
Contributor
|
Shouldn't it be added here as well? |
moiseev
approved these changes
Feb 8, 2017
Contributor
Author
|
Yes, that’s a different PR ;-)
Kim
… On Feb 8, 2017, at 2:49 PM, Maxim Moiseev ***@***.***> wrote:
Shouldn't it be added here <https://github.com/apple/swift/blob/master/stdlib/public/SDK/Dispatch/Time.swift#L37> as well?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#210 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AYFzK7pBUJO7QMCheiP-uZkaHEZBz5xZks5rakaDgaJpZM4L7d81>.
|
ktopley-apple
changed the title
…seconds: 0) (Radar 28814085) (SR-2807)
mwwa
approved these changes
Feb 10, 2017
Contributor
|
please don't merge PRs with merge commits, branches should be rebased and flattened before merging them to trunk for a clean history. |
das
pushed a commit
that referenced
this pull request
Feb 21, 2017
Adding documentation to clarify the result of DispatchTime(uptimeNanoseconds: 0) Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation does not make it clear that DispatchTime(uptimeNanoseconds: 0) produces a value that represents the current nanoseconds since boot, not the time of boot. The fix adds a documentation comment to that effect.
(Radar 28814085)
Resolves SR-2807.