Correct the Xcode fixits for dispatch_async() and dispatch_group_async() #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c(). rdar://problem/27915073
Contributor
Author
|
@swift-ci Please test |
Contributor
Author
|
Test failure is unrelated to this change. |
Contributor
Author
|
@swift-ci Please test |
Contributor
Author
|
@dgrove-oss could you please take a look at the build output for Linux? It's failing with a timeout in the SwiftPM tests. |
Contributor
|
I think there is something broken in how the libdispatch PR testing is being done. It has been habitually failing on this swiftPM subtest (and we have been ignoring the failure, merging the changes, and not seeing the failure in the main runs). I'll ask for help on swift-dev list to see if anyone has an idea of what could be wrong. |
Contributor
Author
|
@dgrove-oss thanks. The failure is clearly not related to the change, so I am going to go ahead and merge. |
das
pushed a commit
that referenced
this pull request
Feb 21, 2017
Correct the Xcode fixits for dispatch_async() and dispatch_group_async() Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same change was already made in the swift repo (swiftlang/swift#6958)
rdar://problem/27915073