Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: swiftlang/swift-corelibs-libdispatch
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2053307
Choose a base ref
...
head repository: swiftlang/swift-corelibs-libdispatch
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 9566a13
Choose a head ref
  • 16 commits
  • 10 files changed
  • 5 contributors

Commits on Mar 31, 2023

  1. Configuration menu
    Copy the full SHA
    9c72b97 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #784 from tristanlabelle/init-once-call-conv

    Fix build break due to calling convention mismatch on Windows
    compnerd authored Mar 31, 2023
    Configuration menu
    Copy the full SHA
    fa1b4ae View commit details
    Browse the repository at this point in the history
  3. build: slightly improve the build for libdispatch

    Avoid polluting the build directory a small amount given that we can use
    `-fmodule-map-file=` for the C/C++ build of libdispatch.  Unfortunately,
    for the Swift build, we need to have the file copied over due to the
    umbrella header resolution.
    
    Hopefully this reduces some of the race conditions that we have seen in
    the build.
    
    Thanks to @dgregor for reminding me of the flag!
    compnerd committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    1848afe View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2023

  1. dispatch: attempt to use a VFS overlay

    Use a VFS overlay to avoid polluting the source tree.
    compnerd committed Apr 1, 2023
    Configuration menu
    Copy the full SHA
    ed909bb View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2023

  1. Merge pull request #785 from compnerd/references-available-upon-request

    build: slightly improve the build for libdispatch
    compnerd authored Apr 3, 2023
    Configuration menu
    Copy the full SHA
    a5167e2 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. Mark DispatchTimeInterval as Sendable

    This is an `enum` with associated values of `Int` type that are all `Sendable`, so should be safe mark the whole `enum` as such.
    
    Resolves #787.
    MaxDesiatov authored Apr 21, 2023
    Configuration menu
    Copy the full SHA
    29ebbaa View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2023

  1. Configuration menu
    Copy the full SHA
    7c19a4f View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2023

  1. Configuration menu
    Copy the full SHA
    7fb9d5c View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. build: add a link against AdvAPI32 on Windows

    The `WaitChain*` functions require linking against AdvAPI32.
    compnerd committed May 23, 2023
    Configuration menu
    Copy the full SHA
    966ff45 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #790 from compnerd/linking

    build: add a link against AdvAPI32 on Windows
    compnerd authored May 23, 2023
    Configuration menu
    Copy the full SHA
    0180b4e View commit details
    Browse the repository at this point in the history
  3. shims: fix a subtle bug in semaphore initialisation on Windows

    This function is the initializer for the semaphore.  The seamphore
    storage itself may be stack allocated (or heap allocated) but without
    guarantee of 0-initialisation.  As a result, the subsequent CAS for the
    atomic replacement will fail silently, leaving the previously non-zero
    value in place, indicating that the value is a valid handle.  This would
    fail randomly and would ultimately result in a crash in the
    `CloseHandle` call associated with the clean up.
    
    This issue was identified by SwiftLint on Windows.
    compnerd committed May 23, 2023
    Configuration menu
    Copy the full SHA
    df7fa52 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2023

  1. Merge pull request #791 from compnerd/atomic-memset

    shims: fix a subtle bug in semaphore initialisation on Windows
    compnerd authored May 24, 2023
    Configuration menu
    Copy the full SHA
    2725ced View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. dispatch: install the correct modulemap when building static

    There is a subtle difference between libdispatch built dynamically and
    statically: DispatchStubs.  We erroneously emit ObjC runtime calls into
    the build and the stubs provides a shim to provide a definition on
    non-ObjC runtime enabled targets.  When built dynamically, this is
    internalised and distributed as part of dispatch.dll/libdispatch.so,
    however when built statically, the consumer is responsible for linking
    against DispatchStubs.  The modulemap reflects this and we need to
    ensure that we correctly provide that modulemap.
    
    Thanks to @MaxDesiatov for the help with debugging and testing a fix for
    this!
    
    Fixes: rdar://23335318
    compnerd committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    a0715dc View commit details
    Browse the repository at this point in the history
  2. Merge pull request #793 from compnerd/static

    There is a subtle difference between libdispatch built dynamically and statically: DispatchStubs. We erroneously emit ObjC runtime calls into the build and the stubs provides a shim to provide a definition on non-ObjC runtime enabled targets. When built dynamically, this is internalised and distributed as part of dispatch.dll/libdispatch.so, however when built statically, the consumer is responsible for linking against DispatchStubs. The modulemap reflects this and we need to ensure that we correctly provide that modulemap.
    
    Thanks to @MaxDesiatov for the help with debugging and testing a fix for this!
    
    Related: rdar://23335318
    compnerd authored Jun 5, 2023
    Configuration menu
    Copy the full SHA
    10d9f92 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Configuration menu
    Copy the full SHA
    0c38954 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. Merge pull request #796 from tristanlabelle/clamp-pipe-WriteFile

    Prevent infinite attempts to write to Win32 pipes
    compnerd authored Jun 15, 2023
    Configuration menu
    Copy the full SHA
    9566a13 View commit details
    Browse the repository at this point in the history
Loading