SR-3052. Incorrect string result for String methods with non latin symbols #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we fix this issue without introducing a new length function for CFString? There is no "CFStringGetLengthUTF8" function on Darwin and I don't think we should introduce one. CFString has the |
|
I'll look into this more. Thanks for the tip on |
|
@parkera updated fix. Tests is passing. |
|
Thanks! |
|
@swift-ci please test |
|
Ok, don't know why the tests are stuck. Trying again. |
|
@swift-ci please test |
|
Looks like everything is ok now |
This was referenced Nov 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue: https://bugs.swift.org/browse/SR-3052
Added tests that cover this issue.
Implemented possible fix by providing correct UTF8-length for
_CFStringCreateByAddingPercentEncodingWithAllowedCharactersand_CFStringCreateByRemovingPercentEncodingAlso switched to
CFStringGetLengthUTF8method for string length where UTF-8 encoding is used.