SR-2301 - Fix XMLParser #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XMLParser was completely broken, even though the bridging was available and things are 99% complete. This PR adds a number of tests to show the problem, and fixes a number of issues:
bomChunkparsing was broken. There was no way for the parser to actually be constructed.startElementandendElementI believe was wrong. I had trouble fixing the logic for the nullability changes and decided that it was easier to re-write things.There's a lot of code in this file hasn't been spruced up in a while and doesn't follow many swift best practices. I'm not sure what the policy was on cleaning things up was, so I tried to just focus on my bugs. However I would be surprised if a cleanup didn't find a few more issues.
Brian King