Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate cString on non-Darwin (#3885) #5190

Merged
merged 3 commits into from
Mar 24, 2025
Merged

Deprecate cString on non-Darwin (#3885) #5190

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
630cd24
Deprecate cString on non-Darwin (#3885)
parkera Mar 17, 2025
5740fc6
Address review feedback
parkera Mar 17, 2025
14980ca
Undeprecate one version of the API, which can be implemented correctly
parkera Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Sources/Foundation/NSStringAPI.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,6 +632,7 @@ extension StringProtocol {

/// Returns a representation of the string as a C string
/// using a given encoding.
@available(*, deprecated, message: "On platforms without Objective-C autorelease pools, use withCString instead")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an NSString.cString(using:) that has the same issue, FWIW

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should refer people to use String.withCString(encodedAs:_) instead of this message.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. There is one place we use this API in keyed archiver that will have to get a follow-up.

public func cString(using encoding: String.Encoding) -> [CChar]? {
return withExtendedLifetime(_ns) {
(s: NSString) -> [CChar]? in
Expand Down