Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.1] Process: unwrap the posix_spawnattr_t on Android #5185

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

hjyamauchi
Copy link
Contributor

This is required as while posix_spawnattr_init permits a nullable type, posix_spawnattr_setflags properly expects a non-null parameter. Unwrap the newly minted spawnattr or abort if the allocation failed.

Cherry pick commit #5179

This is required as while `posix_spawnattr_init` permits a nullable
type, `posix_spawnattr_setflags` properly expects a non-null parameter.
Unwrap the newly minted spawnattr or abort if the allocation failed.

Cherry pick commit #5179
@hjyamauchi
Copy link
Contributor Author

@swift-ci please test

@compnerd compnerd changed the title Process: unwrap the posix_spawnattr_t on Android [6.1] Process: unwrap the posix_spawnattr_t on Android Mar 5, 2025
@hjyamauchi
Copy link
Contributor Author

Explanation: Fix an Android build failure.
Scope: The Android build.
Issues: No issue
Original PRs: #5179
Risk: The change affects the Android build only and low risk because we don't have official Android builds yet.
Testing: The 6.1 CI
Reviewers: @compnerd @finagolfin

@compnerd compnerd requested a review from parkera March 5, 2025 23:46
@compnerd
Copy link
Member

compnerd commented Mar 5, 2025

@swift-ci please test

Copy link
Member

@finagolfin finagolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@finagolfin finagolfin merged commit 21bb65e into release/6.1 Mar 6, 2025
2 checks passed
@parkera parkera deleted the 6.1cp branch March 6, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants