[6.1] Remove incorrect guard check for Android (#5171)
#5175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
finagolfin
changed the title
guard check for Android (#5171)guard check for Android (#5171)
finagolfin
changed the title
guard check for Android (#5171)guard check for Android (#5171)
parkera
approved these changes
Feb 24, 2025
|
adding @itingliu for visibility, but this looks good to me too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: This
guardcheck currently always fails on Android becausespawnAttrsis set tonilon Android just two lines above. There was some talk of making changes to the Android NDK upstream or nullability annotations instead by @hyp a couple months ago, which is why we left this in temporarily, but nothing came of it and he hasn't responded in months, so let's just fix this for now.Scope: Only affects Android
Issue: None
Original PR: #5171
Risk: None
Testing: I apply this patch on my Android CI for the last couple months, works well.
Reviewer: @hyp
@itingliu, mind reviewing?