Add default implementations for three default protocol conformances in the URLSessionDelegate family #5022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@jrflat to review (and also to verify behavior compatibility with Darwin) |
|
I think at the very least we need test cases to cover the desired new behavior. |
jrflat
reviewed
Jul 22, 2024
Sources/FoundationNetworking/URLSession/URLSessionDelegate.swift
Outdated
Show resolved
Hide resolved
jrflat
reviewed
Jul 22, 2024
…n the URLSessionDelegate family Implementing these callbacks without calling the completion handler causes hangs in cases where these methods are called. Add reasonable default behaviors for all of them, to prevent this. This issue has been in place for at least 8 years for one of these callbacks.
jakepetroules
force-pushed
the
urlsessiondelegate-default-implementations
branch
from
d43a53f to
3420746
Compare
|
Thanks for the review @jrflat! Does this look right, now? |
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing these callbacks without calling the completion handler causes hangs in cases where these methods are called. Add reasonable default behaviors for all of them, to prevent this.
This issue has been in place for at least 8 years for one of these callbacks.