Remove URL in favor of swift-foundation's URL #4955
Merged
+122
−1,098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest commit updates the swift-foundation dependency to the commit that resolves the two test failures. Now all tests pass on linux with this change (aside from the one test that is disabled) |
parkera
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
URLtype in favor of theURLtype provided by swift-foundation. It contains a few minor test adjustments to account for the new URL parser (which can behave slightly differently).This disables one test which we'll come back to soon to update for the new parsing behavior (cc @jrflat), otherwise all but 2 tests pass and those two failures will be fixed by swiftlang/swift-foundation#602 which contains a bug-fix for
URLs created from relative paths. I'll update the dependency's commit hash once that PR is merged