NSNotification.Name is sendable #4875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
approved these changes
Feb 15, 2024
|
@swift-ci please test |
jumhyn-browser
force-pushed
the
nsnotification-name-sendable
branch
from
1879229 to
81e494c
Compare
|
@swift-ci please test |
|
Windows run succeeded but didn't get linked back here for some reason. @parkera any idea on the macOS failure here? I thought @kateinoigakukun's #4873 should have addressed this but I rebased onto that change this morn |
|
@swift-ci please test Windows platform |
|
I think #4873 addressed something completely different for the macOS builds. I'm not sure why we are even attempting to run argument parser's tests in the SCL-F PRs. |
parkera
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.