Replace calls to CFStringCreateWithCString with CFSTR macro #4717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AZero13
force-pushed
the
CFStringCreateWithCString
branch
from
751a2ca to
c628661
Compare
|
@compnerd Can we do a full test, but with all platforms this time? |
compnerd
requested changes
Mar 17, 2023
This would save performance by removing unnecessary calls to CFStringCreateWithCString. Note: Windows cannot CFSTR to private symbols, so CFXMLInterface is excluded from changes.
AZero13
force-pushed
the
CFStringCreateWithCString
branch
from
c628661 to
0358f2b
Compare
|
@compnerd Reverted. |
|
@swift-ci please test |
|
@compnerd They passed! |
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would save performance by removing unnecessary calls to CFStringCreateWithCString.
Note: Windows cannot CFSTR to private symbols, so CFXMLInterface is excluded from changes.