Foundation/Unit: add {m,u,p,n}second units to UnitDuration #4708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@parkera this seems like a straightforward change, matches the current documentation at https://developer.apple.com/documentation/foundation/unitduration. I can't seem to find when the API was introduced, but existed prior to Xcode 14. Any objections to merging this? |
|
@swift-ci please test Windows platform |
|
@swift-ci please test Linux platform |
Seems like a spurious failure. |
parkera
approved these changes
Mar 30, 2023
|
as always, super appreciative of your cross platform work @compnerd. thanks for pushing to get this in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not 100% sure this wasn't implemented elsewhere, but i didn't see these units