Process: disable Nagle on Windows #4707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows does not have a native `socketpair` interface and so we emulate that locally. Furthermore, the use of `socketpair` on the other platforms uses an `AF_UNIX` (Unix Domain Socket) which is not guaranteed to be available on Windows. As a result, we workaround that by using an `AF_INET` address family socket. This will by default have Nagle enabled which can potentially cause some delays when processing a message. We have observed occasional hangs in the process handling which may be possibly be attributed to the buffering. Disable nagle on the sender side in the hopes of a more reliable connection.
|
@swift-ci please test |
|
CC: @pcbeard |
|
CC: @parkera |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows does not have a native
socketpairinterface and so we emulate that locally. Furthermore, the use ofsocketpairon the other platforms uses anAF_UNIX(Unix Domain Socket) which is not guaranteed to be available on Windows. As a result, we workaround that by using anAF_INETaddress family socket. This will by default have Nagle enabled which can potentially cause some delays when processing a message. We have observed occasional hangs in the process handling which may be possibly be attributed to the buffering. Disable nagle on the sender side in the hopes of a more reliable connection.