Update for SE-0025 ('private' and 'fileprivate') #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, I wonder if we should actually consider some of these for |
|
Good to merge as soon as the binary drops of the toolchain have this feature |
|
Both |
|
Today's toolchain should have 'fileprivate' support (treating it largely the same as 'private'). Okay to merge? |
|
@swift-ci please test |
|
CI is in an awful state; let's make sure we are not making things worse. |
|
Good call. Looks like it passed—good to go? |
1 task
jrose-apple
added a commit
to swiftlang/swift
that referenced
this pull request
Jul 26, 2016
Similar to the work in swiftlang/swift-corelibs-foundation#445. Groundwork for SE-0025 ('private' and 'fileprivate'). No intended functionality change.
jrose-apple
added a commit
to swiftlang/swift
that referenced
this pull request
Jul 26, 2016
Similar to the work in swiftlang/swift-corelibs-foundation#445. Groundwork for SE-0025 ('private' and 'fileprivate'). No intended functionality change.
DaveLiu888
pushed a commit
to DaveLiu888/swift-corelibs-foundation
that referenced
this pull request
Jul 28, 2016
phausler
pushed a commit
that referenced
this pull request
Aug 4, 2016
millenomi
pushed a commit
that referenced
this pull request
Nov 11, 2020
Similar to the work in #445. Groundwork for SE-0025 ('private' and 'fileprivate'). No intended functionality change.
millenomi
pushed a commit
that referenced
this pull request
Nov 11, 2020
Similar to the work in #445. Groundwork for SE-0025 ('private' and 'fileprivate'). No intended functionality change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SE-0025 makes
privaterestrict access to a lexical scope; the Swift 2 behavior is now namedfileprivate. At the time of this pull request, the compiler treats bothprivateandfileprivateas havingfileprivatesemantics, but that will soon change.Supersedes #413; the latest amendment to SE-0025 permits some accesses that the original model (or at least our interpretation of it) would have forbidden. This was done by hand, so it's possible I missed a few cases, but it's at least a smaller diff.