Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement some methods for NSAttributedString and NSMutableAttributedString #364

Merged
merged 1 commit into from
Jun 15, 2016
Merged

Implement some methods for NSAttributedString and NSMutableAttributedString #364

merged 1 commit into from
Jun 15, 2016

Conversation

eyeplum
Copy link
Contributor

@eyeplum eyeplum commented May 14, 2016

This pull request contains the following NSAttributedString and NSMutableAttributedString method implementations:

NSAttributedString

  • attributesAtIndex(_ location: Int, longestEffectiveRange range: NSRangePointer, inRange rangeLimit: NSRange) -> [String : AnyObject]
  • attribute(_ attrName: String, atIndex location: Int, longestEffectiveRange range: NSRangePointer, inRange rangeLimit: NSRange) -> AnyObject?

NSMutableAttributedString

  • init(string str: String)
  • mutableString: NSMutableString
  • addAttribute(_ name: String, value: AnyObject, range: NSRange)

@eyeplum eyeplum changed the title Implement more methods for NSAttributedString Implement some methods for NSAttributedString and NSMutableAttributedString May 14, 2016
@parkera
Copy link
Contributor

parkera commented May 20, 2016

@swift-ci please test

@parkera
Copy link
Contributor

parkera commented May 20, 2016

Neat

@eyeplum
Copy link
Contributor Author

eyeplum commented May 20, 2016

It seems that some unrelated tests were failing:

Test Case 'TestNSNumber.test_NumberWithBool' started at 00:50:58.936
TestFoundation/TestNSNumber.swift:43: error: TestNSNumber.test_NumberWithBool : XCTAssertEqual failed: ("Optional(-1)") is not equal to ("Optional(1)") - 
TestFoundation/TestNSNumber.swift:44: error: TestNSNumber.test_NumberWithBool : XCTAssertEqual failed: ("Optional(255)") is not equal to ("Optional(1)") - 
TestFoundation/TestNSNumber.swift:45: error: TestNSNumber.test_NumberWithBool : XCTAssertEqual failed: ("Optional(255)") is not equal to ("Optional(1)") - 
TestFoundation/TestNSNumber.swift:46: error: TestNSNumber.test_NumberWithBool : XCTAssertEqual failed: ("Optional(255)") is not equal to ("Optional(1)") - 
TestFoundation/TestNSNumber.swift:47: error: TestNSNumber.test_NumberWithBool : XCTAssertEqual failed: ("Optional(255)") is not equal to ("Optional(1)") - 
TestFoundation/TestNSNumber.swift:48: error: TestNSNumber.test_NumberWithBool : XCTAssertEqual failed: ("Optional(255)") is not equal to ("Optional(1)") - 
TestFoundation/TestNSNumber.swift:49: error: TestNSNumber.test_NumberWithBool : XCTAssertEqual failed: ("Optional(255)") is not equal to ("Optional(1)") - 
TestFoundation/TestNSNumber.swift:50: error: TestNSNumber.test_NumberWithBool : XCTAssertEqual failed: ("Optional(255)") is not equal to ("Optional(1)") - 
TestFoundation/TestNSNumber.swift:52: error: TestNSNumber.test_NumberWithBool : XCTAssertEqual failed: ("Optional(255.0)") is not equal to ("Optional(1.0)") - 
TestFoundation/TestNSNumber.swift:53: error: TestNSNumber.test_NumberWithBool : XCTAssertEqual failed: ("Optional(255.0)") is not equal to ("Optional(1.0)") - 
Test Case 'TestNSNumber.test_NumberWithBool' failed (0.001 seconds).
TestFoundation/TestNSJSONSerialization.swift:693: error: TestNSJSONSerialization.test_serialize_number : XCTAssertEqual failed: ("Optional("[0,-1]")") is not equal to ("Optional("[0,1]")") - 

@eyeplum
Copy link
Contributor Author

eyeplum commented May 20, 2016

Rebased to master and squashed the commits.

@eyeplum
Copy link
Contributor Author

eyeplum commented May 30, 2016

Hello, @parkera any update on this? Thanks.

@parkera
Copy link
Contributor

parkera commented Jun 15, 2016

@swift-ci please test

@parkera parkera merged commit 2c3f2ca into swiftlang:master Jun 15, 2016
kateinoigakukun pushed a commit to kateinoigakukun/swift-corelibs-foundation that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants