Units: Add UnitInformationStorage #3059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test. |
|
@swift-ci Please test Linux platform. |
1 similar comment
|
@swift-ci Please test Linux platform. |
|
LGTM, but ping me once it's out of draft so I can merge it. |
|
@millenomi out of draft! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for UnitInformationStorage, which seems to be the only Unit to not be implemented per: https://gist.github.com/ianpartridge/9e010553594b9bbf45fa8628af7fb562
Additional Information
The docs on the developer page also need to be corrected. The usage of
eshould really be an exponent (unless lowercaseeis intended to mean exponent, but that's not very clear). For example:should be corrected to