CoreFoundation: add US/Pacific TimeZone mapping for Windows
#3043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows does not have the same timezone information available as the other platforms. We import a subset of the CLDR (due to duplicate mappings) into Foundation to provide the translation. `TestCalendar/test_nextDate` usees `US/Pacific` for a test case. Explicitly add this to the Olson -> Windows mapping. We cannot provide a Windows -> Olson mapping entry for this value as that would have multiple values for the canonical `America/Los_Angeles` key. This repairs the `TestCalendar/test_nextDate` test case on Windows.
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows does not have the same timezone information available as the
other platforms. We import a subset of the CLDR (due to duplicate
mappings) into Foundation to provide the translation.
TestCalendar/test_nextDateuseesUS/Pacificfor a test case.Explicitly add this to the Olson -> Windows mapping. We cannot provide
a Windows -> Olson mapping entry for this value as that would have
multiple values for the canonical
America/Los_Angeleskey. Thisrepairs the
TestCalendar/test_nextDatetest case on Windows.