SR-13837: Swift Decimal type crashes on a specific double value #2926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci test linux |
- If a Double is close but less than UInt64.max, then UInt64(value) can crash. Add a check to provide the next closest value. - Bounds check the exponent when converting a Double to Decimal. This prevents initialising from Double values that cannot be stored correctly. - Add extra checks when passing _length and _exponent to initializers.
|
@swift-ci test |
|
@swift-ci test linux |
|
@swift-ci test and merge |
1 similar comment
|
@swift-ci test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a Double is close but less than UInt64.max, then UInt64(value) can
crash. Add a check to provide the next closest value.
Bounds check the exponent when converting a Double to Decimal.
This prevents initialising from Double values that cannot be
stored correctly.
Add extra checks when passing _length and _exponent to initializers.