Foundation: extract cfSource from RunLoop._Source
#2893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making `cfSource` a member within the structure prevents allowing overriding of the `open` class as the type it returns cannot be deserialised. Because the member is not a stored property, extract it to an extension which removes it from the vtable. This allows the use of the private type in an external context.
|
Please also file separately to figure out why Windows could not handle this computed variable in this context? |
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making
cfSourcea member within the structure prevents allowingoverriding of the
openclass as the type it returns cannot bedeserialised. Because the member is not a stored property, extract it
to an extension which removes it from the vtable. This allows the use
of the private type in an external context.