Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSSet: add missing convenience initializer #2883

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Conversation

egorzhdan
Copy link
Contributor

This initializer exists in the macOS version of Foundation, but isn't present on Linux/Windows.
While it doesn't add any new functionality, it simplifies porting existing code to those platforms.

This initializer exists in the macOS version of Foundation
@MaxDesiatov
Copy link
Contributor

@swift-ci please test

@compnerd
Copy link
Member

I see https://developer.apple.com/documentation/foundation/nsset/1574825-setwithobjects?language=objc but it doesn't seem to have the corresponding interface in the Swift view. The change itself LGTM, assuming @millenomi doesn't know of a reason that the interface is missing. However, if there is a reason, it certainly should be indicated with a comment.

@egorzhdan
Copy link
Contributor Author

It exists for Swift as well: https://developer.apple.com/documentation/foundation/nsset/1407975-init

I assume Swift isn't shown in the "Language" popup on https://developer.apple.com/documentation/foundation/nsset/1574825-setwithobjects?language=objc because this is a static method in ObjC but an initializer in Swift.

@compnerd
Copy link
Member

Lets wait for tomorrow just to allow @millenomi a chance to look at it as well, but with that last bit, I think that this is perfectly fine.

@millenomi
Copy link
Contributor

@swift-ci please test and merge

@swift-ci swift-ci merged commit 82b8fa2 into swiftlang:main Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants