-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for Swift array dynamic cast to NSObject #2874
Conversation
@swift-ci please test |
So, it fails on Linux too |
eba2329
to
8bf660c
Compare
Has anything changed substantially since the last push? Would you like me to retrigger CI for it? |
@MaxDesiatov yes, please, that would be nice. Now it is expected-to-fail, so tests should pass. I would look into the reason of this behavior later. |
This comment has been minimized.
This comment has been minimized.
@swift-ci please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! If there is an SR, would be good to reference it.
8bf660c
to
3c949c3
Compare
I was wrong in test expectations. We should expect the value to be not nil. This doesn't affect the issue itself, as dynamic cast is still crashes. |
This comment has been minimized.
This comment has been minimized.
1 similar comment
@swift-ci please test |
@swift-ci test linux |
As the fix for this issue is merged, I am going to enable the test |
3c949c3
to
4c70434
Compare
@swift-ci please test |
1 similar comment
@swift-ci please test |
I am getting crash when trying to perform dynamic cast like this:
While it is possibly a bug in new dynamic casting in compiler, I think it is good to cover it with test already.