Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add locking primitives for TARGET_OS_WASI in CFLocking.h #2867

Merged
merged 2 commits into from
Sep 6, 2020

Conversation

MaxDesiatov
Copy link
Contributor

@MaxDesiatov MaxDesiatov commented Sep 3, 2020

WebAssembly/WASI doesn't support multi-threading yet (as reported in SR-12097), so these primitives don't do anything in this single-threaded environment, but allow the rest of the code using them to compile.

WebAssembly/WASI doesn't support multi-threading yet, so these primitives don't do anything in this single-threaded environment, but allow the rest of the code using them to compile.
@MaxDesiatov

This comment has been minimized.

@MaxDesiatov
Copy link
Contributor Author

@swift-ci please test

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me; please wait for @millenomi to take a look as well.

@millenomi
Copy link
Contributor

@swift-ci please test and merge

@swift-ci swift-ci merged commit 807e415 into master Sep 6, 2020
@MaxDesiatov MaxDesiatov deleted the maxd/wasi-locking branch September 6, 2020 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants