Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Fix test_reachable #2504

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Conversation

gmittert
Copy link
Contributor

@gmittert gmittert commented Sep 9, 2019

Windows doesn't have /data or /usr. Since Windows does not guarantee
a drive letter actually existing, defer to NSHomeDirectory to give us a
directory which should always exist.

Windows doesn't have `/data` or `/usr`. Since Windows does not guarantee
a drive letter actually existing, defer to NSHomeDirectory to give us a
directory which should always exist.
@gmittert
Copy link
Contributor Author

gmittert commented Sep 9, 2019

@swift-ci please test

@gmittert
Copy link
Contributor Author

gmittert commented Sep 9, 2019

cc @compnerd

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@compnerd compnerd merged commit fd145c0 into swiftlang:master Sep 9, 2019
@gmittert gmittert deleted the SweetHomeAladata branch September 9, 2019 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants