Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Verification of UTF32 XML on Windows #2503

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Remove Verification of UTF32 XML on Windows #2503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion TestFoundation/TestXMLParser.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,11 @@ class TestXMLParser : XCTestCase {
// If th <?xml header isn't present, any non-UTF8 encodings fail. This appears to be libxml2 behavior.
// These don't work, it may just be an issue with the `encoding=xxx`.
// - .nextstep, .utf32LittleEndian
let encodings: [String.Encoding] = [.utf16LittleEndian, .utf16BigEndian, .utf32BigEndian, .ascii]
var encodings: [String.Encoding] = [.utf16LittleEndian, .utf16BigEndian, .ascii]
#if !os(Windows)
// libxml requires iconv support for UTF32
encodings.append(.utf32BigEndian)
#endif
for encoding in encodings {
let xml = TestXMLParser.xmlUnderTest(encoding: encoding)
let parser = XMLParser(data: xml.data(using: encoding)!)
Expand Down