Parity: NSCoding stragglers: NSCountedSet #2493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- On Darwin, NSCountedSet with items all with count 1 and a NSSet with those same items are equal; make sure this can happen safely in s-c-f too. (This changes the implementation slightly — we now encode counts in _table only if they are higher than 1.) - Implement coding and add fixture tests.
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Darwin, NSCountedSet with items all with count 1 and a NSSet with those same items are equal; make sure this can happen safely in s-c-f too. (This changes the implementation slightly — we now encode counts in _table only if they are higher than 1. Edited to add: Those counts are encoded as one less than the actual count — an object with a count of 1 has no entry in _table, and an object with a count of 2 has an entry in _table equal to 1.)
Implement coding and add fixture tests.