Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] Create a GenerateTestFixtures targets in CMake. #2464

Merged

Conversation

drodriguez
Copy link
Contributor

The target reproduces the basic structure of the Xcode project and
allows other platforms to build easily and test.

The target is not installed intentionally. It is supposed to be a
development tool.

(This would have avoided a problem that was almost introduced in #2462)

The target reproduces the basic structure of the Xcode project and
allows other platforms to build easily and test.

The target is not installed intentionally. It is supposed to be a
development tool.
@millenomi
Copy link
Contributor

I'm pretty sure it doesn't build on s-c-f. It's meant to be built with Darwin Foundation only, for now.

@millenomi
Copy link
Contributor

@swift-ci please test

@millenomi
Copy link
Contributor

Let's see if I'm wrong.

@drodriguez
Copy link
Contributor Author

From what I found in the documentation, the tool also handles building in Linux, but it is indeed more useful in Darwin. Feel free to merge or not. It would be useful to avoid unintentional breakage, at least.

@millenomi
Copy link
Contributor

I wrote Linux support in it, but I have never tested it.

@millenomi
Copy link
Contributor

Eh, no time like the present.

@millenomi millenomi merged commit aa080d1 into swiftlang:master Aug 15, 2019
@drodriguez drodriguez deleted the cmake-generate-test-fixtures-target branch August 18, 2019 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants