FileManager: Add missing replaceItemAt(_:withItemAt:backupItemName:options:) #2416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
spevans
commented
Jul 15, 2019
spevans
commented
- This just wraps replaceItem(at:withItemAt:backupItemName:options:)
…tions:) - This just wraps replaceItem(at:withItemAt:backupItemName:options:)
|
@swift-ci test linux |
millenomi
suggested changes
Jul 15, 2019
There was a problem hiding this comment.
That's not the spelling of that method in the docs (and thus on Darwin): https://developer.apple.com/documentation/foundation/filemanager/1412432-replaceitem
What's the use case here?
|
I was looking at https://developer.apple.com/documentation/foundation/filemanager/2293212-replaceitemat It also autocompletes in Xcode playgrounds unless Im missing something obvious? |
|
My bad, you're correct. Thanks for picking this up. |
millenomi
approved these changes
Jul 15, 2019
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.