Implement _contentsEqual on Windows #2411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmittert
commented
Jul 12, 2019
|
@swift-ci please test linux |
compnerd
reviewed
Jul 16, 2019
| guard DWORD(FILE_ATTRIBUTE_REPARSE_POINT) & path1Attrs == DWORD(FILE_ATTRIBUTE_REPARSE_POINT) | ||
| && DWORD(FILE_ATTRIBUTE_REPARSE_POINT) & path2Attrs == FILE_ATTRIBUTE_REPARSE_POINT else { | ||
| return false | ||
| } |
There was a problem hiding this comment.
Huh? What am I missing? Isn't this the condition that is in the if?
There was a problem hiding this comment.
The inner one is &&, the outer is ||. If either is a reparse point, go into the if, but if one is not a reparse point, the immediately bail out. Sadly there's no logical XOR which might make that clearer.
Compared to the POSIX implementation, this: - Uses the same _compareFile and _compareDirectory utilities. - Implements Symlink comparison with `_destinationOfSymbolicLink` - Doesn't handle devices since there's no reasonable way to check for that equivalence on Windows (as far as I'm aware). If given a device, it will instead always return false. This is probably fine since devices tend to be less file like on Windows anyways.
gmittert
force-pushed
the
WhichOneOfYouIsTheOriginal
branch
from
bd2efc8 to
6bc00b2
Compare
|
@millenomi - any additional comments from you? |
|
@swift-ci please test Linux |
|
@swift-ci please test linux |
1 similar comment
|
@swift-ci please test linux |
|
I think that all the review comments have been addressed, lets get this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compared to the POSIX implementation, this:
_destinationOfSymbolicLinkthat equivalence on Windows (as far as I'm aware). If given a device, it
will instead always return false. This is probably fine since devices
tend to be less file like on Windows anyways.