Unit.swift Store units #2371
Closed
Unit.swift Store units #2371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store units so each is only created once Remove redundant initializers
millenomi
reviewed
Jul 5, 2019
Foundation/Unit.swift
Outdated
|
|
||
| // Store is private, access members by `stored(at:)` | ||
| // Set members by `stored(_,at:)` | ||
| private static var ObjectStore = [Unit?](repeating: nil, count: StoreIndex.max) |
There was a problem hiding this comment.
Style: lowercase. objectStore. Maybe cachedDimensions, storedDimensions?
millenomi
reviewed
Jul 5, 2019
Foundation/Unit.swift
Outdated
| private static var ObjectStore = [Unit?](repeating: nil, count: StoreIndex.max) | ||
|
|
||
| fileprivate static func stored(at index: StoreIndex) -> Unit? { | ||
| return ObjectStore[index.rawValue] |
There was a problem hiding this comment.
These aren't thread-safe, and likely need a lock.
millenomi
suggested changes
Jul 5, 2019
|
@swift-ci please test |
|
@e78l Are you still interested in this patch? |
|
@swift-ci please test Linux |
1 similar comment
|
@swift-ci please test Linux |
|
Hoping to push the changes this week |
e78l
force-pushed
the
measfmt-pt2
branch
3 times, most recently
from
1451951 to
2262826
Compare
|
The Swift project moved the default branch to More detail about the branch update - https://forums.swift.org/t/updating-branch-names/40412 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduced code size some w/single initializer in Dimension extension (vs 1 init/Unit* class). Added to size with big enum (stats off Ubuntu below) and other minor changes.
This would be a first step in the Measurement+DateComponents formatter implementation I would like to propose: e78l/swift-corelibs-foundation@613b64b
After PR:
text data bss dec hex filename
8773109 386873 151560 9311542 8e1536 libFoundation.so
Before PR, off 17912de
text data bss dec hex filename
8711549 386873 151528 9249950 8d249e libFoundation.so