Foundation: Process is unavailable on android
#2356
Conversation
|
CC: @millenomi |
|
@swift-ci please test |
|
Or you could get #2228 merged, after which the Android portion of this pull is unnecessary. |
Foundation/NSObjCRuntime.swift
Outdated
| (UnitVolume.self, "NSUnitVolume"), | ||
| (UnitTemperature.self, "NSUnitTemperature"), | ||
| ] | ||
| #if !(os(iOS) || os(Android) |
There was a problem hiding this comment.
Clearly pulling changes between two repositories is a great idea 🙄
|
I would prefer for someone to give another review to #2228 instead of merging this. In any case, after the change proposed by Simon, this would work. |
compnerd
force-pushed
the
i-am-currently-unavailable-please-leave-a-message
branch
from
109ad30 to
df7968e
Compare
|
Well, for the iOS target, this will still be required. I think that if that is finalised and merged first, then I can remove the android clause, otherwise, if this gets merged first, you could just remove the android clause after a rebase. |
|
@swift-ci please test |
Foundation/NSObjCRuntime.swift
Outdated
| (UnitTemperature.self, "NSUnitTemperature"), | ||
| ] | ||
| internal let _NSClassesRenamedByObjCAPINotes: [(class: AnyClass, objCName: String)] = { | ||
| let map: [(AnyClass, String)] = [ |
There was a problem hiding this comment.
I thing the compiler is telling you that you have to change this to var to be able to append later.
Android does not provide Process (NSTask) like iOS. Do not reference it in such situations.
compnerd
force-pushed
the
i-am-currently-unavailable-please-leave-a-message
branch
from
df7968e to
826a849
Compare
|
@swift-ci please test |
Android does not provide Process (NSTask) like iOS. Do not reference it
in such situations.