Add extensive testing documentation #2333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Copy information critical to producing useful tests from my head onto words on disk. * Simplify the instructions for GenerateTestFixtures by making the version strings used match the expectations of the Fixture extensions, and by making the executable default to its current location for output if not specified. * Remove a path that is local to my machine from the repository.
|
@swift-ci please test linux |
spevans
reviewed
Jun 12, 2019
| // It will look something like this: | ||
|
|
||
| #if NS_FOUNDATION_ALLOWS_TESTABLE_IMPORT | ||
| #if canImport(SwiftFoundation) && !DEPLOYMENT_RUNTIME_OBJC |
There was a problem hiding this comment.
I dont think the !DEPLOYMENT_RUNTIME_OBJC is actually that useful anymore now that canImport(SwiftFoundation) is used. I cant see a situation where canImport(SwiftFoundation) returns true but we DONT import it and instead import Foundation
There was a problem hiding this comment.
True. A patch that fixes this should also fix this documentation in the same swoop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy information critical to producing useful tests from my head onto words on disk.
Simplify the instructions for GenerateTestFixtures by making the version strings used match the expectations of the Fixture extensions, and by making the executable default to its current location for output if not specified.
Remove a path that is local to my machine from the repository.