-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ._hidden on Windows #2332
Conversation
@millenomi Are you okay with adding in attributes, especially ones that are more Windows specific? If not, what would be the better way to add this support? cc @compnerd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Public API cannot be added like this; sorry.
(There is already a private ._hidden attribute, IIRC?) |
I can consider a Windows-only attribute that is prefixed if there is a compellingly strong use case other than completeness; but the right way to do this is to ask for a new API by filing a bug. However, in this case, we already have API that corresponds to this in a more modern API (it's |
I see, I misunderstood how the private attributes worked. I've changed it to use _hidden via URLResource now. |
@swift-ci please test linux |
@swift-ci please test linux |
@swift-ci please test linux |
@swift-ci please test linux |
Windows has a specific attribute to mark a file as hidden as opposed to prefixing ".". This allows setting and getting the attribute.
@swift-ci please test |
Windows has a specific attribute to mark a file as hidden as opposed to
prefixing ".". This allows setting and getting the attribute. On POSIX,
it will return based on the "." prefix and setting it does nothing.