URLCache sketches. Mainly memory cache. #2312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millenomi
reviewed
Jun 6, 2019
| @@ -129,6 +129,9 @@ open class CachedURLResponse : NSObject, NSSecureCoding, NSCopying { | |||
| open class URLCache : NSObject { | |||
|
|
|||
| /*! | |||
| private static let _sharedCacheLock: NSLock = NSLock() | |||
There was a problem hiding this comment.
I was moving commits between branches. The documentation comment should go below the two private variables. I didn’t review the code before pushing, sorry about that.
drodriguez
commented
Jun 7, 2019
| } | ||
| } | ||
|
|
||
| /*! | ||
| private let _memoryCache: _URLMemoryCache<_URLCacheKey, CachedURLResponse> | ||
| private let _diskPath: String | ||
| private let _diskCache: _URLDiskCache<_URLCacheKey, CachedURLResponse> |
There was a problem hiding this comment.
Also happens here. The variables should be outside the comment, not inside.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@millenomi: just in case you work more in
URLCache. I was working on the memory cache, and I think I have a LRU memory cache and some sketches of other parts. It is not completely compatible with the code in #2000, but I think many parts of the code can be used (or at least the ideas contained in them).I can also work on this if you prefer. I have some ideas on how to implement the disk cache (with flat files on disk). I was trying to get
URLSessionand the related classes in a less “unimplemented minefield” state. I also have some work done in the credential storage, if you want it.