convert deployment target to OS #2249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millenomi
reviewed
May 10, 2019
compnerd
force-pushed
the
deployment-targets
branch
from
996bbed to
773b303
Compare
|
@swift-ci please test |
compnerd
force-pushed
the
deployment-targets
branch
from
773b303 to
b7956a7
Compare
compnerd
force-pushed
the
deployment-targets
branch
from
b7956a7 to
b3821e4
Compare
|
@swift-ci please test |
|
@swift-ci please test Linux platform |
millenomi
approved these changes
May 13, 2019
| @@ -18,7 +18,7 @@ | |||
| #include <CoreFoundation/CFPriv.h> | |||
| #include "CFInternal.h" | |||
|
|
|||
| #if DEPLOYMENT_TARGET_MACOSX || DEPLOYMENT_TARGET_EMBEDDED | |||
| #if TARGET_OS_OSX || TARGET_OS_IPHONE | |||
There was a problem hiding this comment.
TARGET_OS_OSX || TARGET_OS_IPHONE is just TARGET_OS_MAC
|
Just the one note above, but good otherwise. |
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.