Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DarwinCompatibility: Restore tests to compiling and working #2240

Merged
merged 1 commit into from
Jun 16, 2019
Merged

DarwinCompatibility: Restore tests to compiling and working #2240

merged 1 commit into from
Jun 16, 2019

Conversation

spevans
Copy link
Contributor

@spevans spevans commented May 9, 2019

No description provided.

@spevans
Copy link
Contributor Author

spevans commented May 9, 2019

@swift-ci test

@spevans
Copy link
Contributor Author

spevans commented May 9, 2019

@swift-ci test linux

@spevans spevans force-pushed the pr_darwin_compat_fixes3 branch from 3ba21bb to eefdd56 Compare May 10, 2019 10:00
@spevans
Copy link
Contributor Author

spevans commented May 10, 2019

@swift-ci test

1 similar comment
@spevans
Copy link
Contributor Author

spevans commented May 10, 2019

@swift-ci test

@spevans
Copy link
Contributor Author

spevans commented May 10, 2019

@swift-ci test linux

millenomi
millenomi suggested changes May 10, 2019
View reviewed changes
@spevans spevans force-pushed the pr_darwin_compat_fixes3 branch from eefdd56 to febe27e Compare May 10, 2019 18:30
@spevans spevans force-pushed the pr_darwin_compat_fixes3 branch from febe27e to 693bd99 Compare June 9, 2019 19:30
@spevans
Copy link
Contributor Author

spevans commented Jun 9, 2019

@swift-ci test

@spevans spevans force-pushed the pr_darwin_compat_fixes3 branch from 693bd99 to 93e22df Compare June 9, 2019 22:35
@spevans
Copy link
Contributor Author

spevans commented Jun 9, 2019

@swift-ci test

1 similar comment
@spevans
Copy link
Contributor Author

spevans commented Jun 10, 2019

@swift-ci test

@spevans spevans force-pushed the pr_darwin_compat_fixes3 branch from 93e22df to 20c842c Compare June 11, 2019 20:29
@spevans
Copy link
Contributor Author

spevans commented Jun 11, 2019

@swift-ci test

@spevans spevans force-pushed the pr_darwin_compat_fixes3 branch from 20c842c to db22dec Compare June 11, 2019 22:35
@spevans
Copy link
Contributor Author

spevans commented Jun 11, 2019

@swift-ci test

@spevans
Copy link
Contributor Author

spevans commented Jun 12, 2019

@swift-ci test linux

@spevans
Copy link
Contributor Author

spevans commented Jun 12, 2019

@millenomi All of the workarounds have bugs filed for them now so I think this is ok to go in.

@spevans
Copy link
Contributor Author

spevans commented Jun 16, 2019

@swift-ci test linux

1 similar comment
@spevans
Copy link
Contributor Author

spevans commented Jun 16, 2019

@swift-ci test linux

@spevans spevans merged commit d7ee5f2 into swiftlang:master Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millenomi millenomi millenomi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spevans @millenomi