Build Fix: TestURL #2158
Merged
Build Fix: TestURL #2158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The catches _are_ exhaustive, and the cast to NSError will never fail, but since it is SwiftFoundation.NSError (and not ObjC NSError) the macOS build cannot detect that. Fix by catching all errors instead.
|
@swift-ci please test and merge |
millenomi
changed the title
|
@swift-ci please test and merge |
1 similar comment
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The catches are exhaustive, and the cast to
NSErrorwill never fail, but since it isSwiftFoundation.NSError(and not ObjCNSError) the macOS build cannot detect that; at least, that's my hypothesis. Fix trivially by catching all errors instead.