Extended Bundle layout testing #2083
Conversation
pvieito
commented
Apr 10, 2019
pvieito
commented
- Added Windows support
- Added both executable and library main executable layouts
- Added test for reverse bundle lookup (required for all implicitly loaded bundles, eg. Bundle.main)
| #else | ||
| return "" | ||
| #endif | ||
| } |
There was a problem hiding this comment.
I wonder if we want to have some constants for this in FileManager as we keep wanting to do this.
There was a problem hiding this comment.
Yea :\ probably a SPI picking up that information from CF (like: Bundle._platformLibraryPrefix/Suffix, Bundle._platformExecutablePrefix/Suffix or similar).
|
I'm not blocking this on the prefix/suffix SPI. |
|
@swift-ci please test and merge |
|
@pvieito This is good to merge after resolving conflicts. |
- Added Windows support - Added both executable and library main executable layouts - Added test for reverse bundle lookup (required for all implicitly loaded bundles, eg. Bundle.main)
|
@millenomi I have merged @compnerd changes and added SPI on CF to check if Freestanding Bundles are supported. |
|
@swift-ci please test and merge |
|
@spevans I think Jenkins has ignored the build request, could you request another one? Thanks! |
|
@swift-ci please test and merge |
|
@compnerd this Swift CI failure is resolved? |
|
@swift-ci please test and merge |
1 similar comment
|
@swift-ci please test and merge |
|
@millenomi Is the CI broken? I don't understand the error: https://ci.swift.org/job/swift-corelibs-foundation-PR-Linux/2451/console |
|
@pvieito CI has been breaking all day for issues unrelated to the s-c-f PRs being tested |
|
@spevans It seems to be working now, could you request a test-and-merge? Thanks! |
|
@swift-ci please test and merge |
| @@ -106,6 +114,14 @@ open class Bundle: NSObject { | |||
| _bundle = result | |||
| } | |||
|
|
|||
| public convenience init?(_executableURL: URL) { | |||
There was a problem hiding this comment.
@pvieito @millenomi Should this method be public? also _supportsFHSBundles and _supportsFreestandingBundle above? If its just for testing shouldn't they be internal?
There was a problem hiding this comment.
@spevans If we mark it internal we would have to guard the tests with NS_FOUNDATION_ALLOWS_TESTABLE_IMPORT, which means that they would not be executed on the Linux CI (and I would like them to be executed on the Linux CI, as I can only test them locally on macOS).
There was a problem hiding this comment.
I thought NS_FOUNDATION_ALLOWS_TESTABLE_IMPORT works for Linux CI because it uses the debug-foundation flag. @millenomi Is that not the case?
