[SR-10156] Fix test_current_working_directory on macOS #2040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millenomi
suggested changes
Mar 29, 2019
| @@ -282,7 +282,11 @@ class TestProcess : XCTestCase { | |||
| } | |||
|
|
|||
| func test_current_working_directory() { | |||
| #if os(macOS) | |||
There was a problem hiding this comment.
We should just replace all of this with NSTemporaryDirectory().
There was a problem hiding this comment.
@millenomi Thank you for the comment!
If we use,
let tmpDir = NSTemporaryDirectory()we will get these errors.
Test Case 'TestProcess.test_current_working_directory' started at 2019-04-01 01:22:45.245
/Users/nafu/Projects/swift-source/swift-corelibs-foundation/TestFoundation/TestProcess.swift:294: error: TestProcess.test_current_working_directory : XCTAssertEqual failed: ("/private/var/folders/gw/nv0tyl695m91txy7thrdppq40000gn/T") is not equal to ("/var/folders/gw/nv0tyl695m91txy7thrdppq40000gn/T/") -
/Users/nafu/Projects/swift-source/swift-corelibs-foundation/TestFoundation/TestProcess.swift:303: error: TestProcess.test_current_working_directory : XCTAssertEqual failed: ("/var/folders/gw/nv0tyl695m91txy7thrdppq40000gn/T") is not equal to ("/var/folders/gw/nv0tyl695m91txy7thrdppq40000gn/T/") - [Q] Do you think it would be better we manipulate for two cases?
- Add
/private/and remove last/for first failure case - Remove last
/for second failure case
|
The Swift project moved the default branch to More detail about the branch update - https://forums.swift.org/t/updating-branch-names/40412 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve: https://bugs.swift.org/browse/SR-10156
Motivation
TestProcess.test_current_working_directory fails on macOS. This fixes the test failure on macOS.