Windows: Implement attributesOfItem with _lstat #2016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spevans
reviewed
Mar 21, 2019
Foundation/FileManager.swift
Outdated
|
|
||
|
|
||
| #if os(Windows) | ||
| result[.type] = s.st_mode |
There was a problem hiding this comment.
This seems wrong as the s.st_mode will include the file permissions, can it be unified with the let type = ... on line 917?
There was a problem hiding this comment.
Ah yeah, that was incorrect. It should now properly get the file type.
spevans
reviewed
Mar 21, 2019
Foundation/FileManager.swift
Outdated
|
|
||
|
|
||
| #if os(Windows) | ||
| result[.posixPermissions] = NSNumber(value: UInt64(s.st_mode & ~UInt16(ucrt.S_IFMT))) |
There was a problem hiding this comment.
It might be worth adding an internal helper to mask s.st_mode to file permissions as it seems to be used in a few places.
gmittert
force-pushed
the
AttributesBy_lstat
branch
2 times, most recently
from
b556b46 to
c8b7627
Compare
|
@swift-ci test |
gmittert
force-pushed
the
AttributesBy_lstat
branch
from
c8b7627 to
66e42e2
Compare
|
Actually reverted a line that wasn't supposed to be changed. It should compile now... |
|
@swift-ci please test |
gmittert
force-pushed
the
AttributesBy_lstat
branch
from
66e42e2 to
9dce82c
Compare
|
Alright, fixed the UInt32/UInt16 thing for realsies this time. Should be good to go now. |
gmittert
force-pushed
the
AttributesBy_lstat
branch
from
9dce82c to
0ea3e4d
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #2015