Update DarwinCompatibilty tests and Xcode project #2007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
- Update Swift version to 5.0 and target deployment version to 10.14. - Rename TestNSProgressFraction.swift to TestProgressFraction.swift to reflect name of test class. - Wrap file in NS_FOUNDATION_ALLOWS_TESTABLE_IMPORT as the type is internal and cant be tested by DarwinCompaitibilityTests. - Add TestPropertyListEncoder.swift and TestDateIntervalFormatter.swift to DarwinCompatibilityTests.
spevans
force-pushed
the
pr_darwin_compatibility_tests_2
branch
from
04610ce to
2c27173
Compare
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DarwinCompatibility: TestStream.seek(to:) is internal API
DarwinCompatibility: Disable tests that use new API not yet in Foundation
Update Swift version to 5.0 and target deployment version to 10.14.
Rename TestNSProgressFraction.swift to TestProgressFraction.swift
to reflect name of test class.
Wrap file in NS_FOUNDATION_ALLOWS_TESTABLE_IMPORT as the type is
internal and cant be tested by DarwinCompaitibilityTests.
Add TestPropertyListEncoder.swift and TestDateIntervalFormatter.swift
to DarwinCompatibilityTests.