-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[SR-10374] URLCache: init method and first time sqlite database setup implemented #2000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
karthikkeyan
wants to merge
6
commits into
swiftlang:master
from
karthikkeyan:karthik/urlcache-database-setup
+185
−5
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
73923a2
URLCache: init method and first time sqlite database setup implemented
karthikkeyan 54b2676
Database connection closed at the end of test_cacheDatabaseIndices un…
karthikkeyan 02436cf
URLCache store and fetch methods implemented using NSKeyedArchiver an…
karthikkeyan 5de096c
Underscore added as prefix for privare type CachePersistence as per A…
karthikkeyan ec38806
Old cache directory keep in disk when new URLCache object assigned
karthikkeyan b5dafd2
Secure archive and unarchive used for cache url response and cacheFil…
karthikkeyan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
// This source file is part of the Swift.org open source project | ||
// | ||
// Copyright (c) 2014 - 2019 Apple Inc. and the Swift project authors | ||
// Licensed under Apache License v2.0 with Runtime Library Exception | ||
// | ||
// See https://swift.org/LICENSE.txt for license information | ||
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors | ||
// | ||
|
||
class TestURLCache: XCTestCase { | ||
|
||
static var allTests: [(String, (TestURLCache) -> () throws -> Void)] { | ||
return [ | ||
("test_cacheFileAndDirectorySetup", test_cacheFileAndDirectorySetup), | ||
] | ||
} | ||
|
||
private var cacheDirectoryPath: String { | ||
guard var cacheDirectoryUrl = FileManager.default.urls(for: .cachesDirectory, in: .userDomainMask).first else { | ||
fatalError("Unable to find cache directory") | ||
} | ||
|
||
cacheDirectoryUrl.appendPathComponent(ProcessInfo.processInfo.processName) | ||
return cacheDirectoryUrl.path | ||
} | ||
|
||
func test_cacheFileAndDirectorySetup() { | ||
// Test default directory | ||
let _ = URLCache.shared | ||
XCTAssertTrue(FileManager.default.fileExists(atPath: cacheDirectoryPath)) | ||
|
||
let fourMegaByte = 4 * 1024 * 1024 | ||
let twentyMegaByte = 20 * 1024 * 1024 | ||
|
||
// Test with a custom directory | ||
let newPath = cacheDirectoryPath + ".test_cacheFileAndDirectorySetup/" | ||
URLCache.shared = URLCache(memoryCapacity: fourMegaByte, diskCapacity: twentyMegaByte, diskPath: newPath) | ||
XCTAssertTrue(FileManager.default.fileExists(atPath: newPath)) | ||
XCTAssertTrue(FileManager.default.fileExists(atPath: cacheDirectoryPath)) | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there plan to keep this value updated as cached responses are added and evicted? Feels like with a big cache and a slow disk, each of these calls might take a while.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me add a
FIXME
comment, I will create a separate PR for optimizing this. My main focus in this PR is to create an initial setup and kick start the implementation. Hope that's ok.