Skip to content

Revert "<SR-9930> Swift CI: TestProcess.test_passthrough_environment : failed - Test failed: InvalidEnvironmentVariable("swift_xcode")" #1926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2019
Merged

Revert "<SR-9930> Swift CI: TestProcess.test_passthrough_environment : failed - Test failed: InvalidEnvironmentVariable("swift_xcode")" #1926

merged 1 commit into from
Feb 19, 2019

Conversation

shahmishal
Copy link
Member

Reverts #1920

@lorentey
Revert "<SR-9930> Swift CI: TestProcess.test_passthrough_environment …
270b42a 
…: failed - Test failed: InvalidEnvironmentVariable("swift_xcode")"
@shahmishal shahmishal requested a review from millenomi February 19, 2019 00:00
@shahmishal
Copy link
Member Author

We are seeing failures in CI and PR testing.

00:21:58.445 Test Case 'TestProcess.test_passthrough_environment' started at 2019-02-18 23:40:01.778
00:21:58.445 
<EXPR>:0: error: TestProcess.test_passthrough_environment : threw error "The operation could not be completed"
00:21:58.445 Test Case 'TestProcess.test_passthrough_environment' failed (0.054 seconds)

@shahmishal
Copy link
Member Author

@swift-ci test and merge

@swift-ci swift-ci merged commit 9aabdda into master Feb 19, 2019
@shahmishal shahmishal deleted the revert-1920-testprocess-fix-pr branch February 19, 2019 01:02
@shahmishal
Copy link
Member Author

@millenomi Just wanted to make sure you are aware that I revert the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millenomi millenomi Awaiting requested review from millenomi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shahmishal @swift-ci @lorentey