NSURLRequest.hash: Implement #1646
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
millenomi
reviewed
Aug 3, 2018
| @@ -194,6 +195,15 @@ class TestURLRequest : XCTestCase { | |||
| XCTAssertNil(originalRequest.allHTTPHeaderFields) | |||
| } | |||
|
|
|||
| func test_hash() { | |||
There was a problem hiding this comment.
Can we test also altering all the entries that contribute to the hash?
There was a problem hiding this comment.
NSObject.hash doesn't allow for custom seeding, so the possibility of collisions makes this unfeasible for properties that have less than a handful possible values -- but we can check most of them!
I think I'll consolidate these hashing PRs to allow for the introduction of some helper functions.
|
Closing; please see followup PR at #1656 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NSURLRequestinheritshashfromNSObject, but overridesisEqual(_:)to compare contents. The default hash uses object identity, so twoNSURLRequestinstances that compare equal underisEqual(_:)can produce non-equal hash values. This also breaks hashing forURLRequest, which calls intoNSURLRequest.hash.Add an implementation for
NSURLRequest.hashthat matchesisEqual(_:).Resolves https://bugs.swift.org/browse/SR-8449