Use a counter instead of array in lengthOfInt #1608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spevans
reviewed
Jun 17, 2018
Foundation/ByteCountFormatter.swift
Outdated
| @@ -354,14 +354,13 @@ open class ByteCountFormatter : Formatter { | |||
| // A helper method to return the length of an int | |||
| private func lengthOfInt(number: Int) -> Int { | |||
| var num = abs(number) | |||
| var length: [Int] = [] | |||
| var length = 0 | |||
|
|
|||
There was a problem hiding this comment.
I see this code is only used to test for length of == 3 or > 3 but maybe length should be at least 1 for a value of 0?
There was a problem hiding this comment.
That is true, should I fix it in same PR or open a new one?
There was a problem hiding this comment.
I think this one is small enough that we can put that fix here as well.
|
@swift-ci please test |
otaviolima
force-pushed
the
minor-optmization
branch
from
14bc497 to
cde89c3
Compare
otaviolima
force-pushed
the
minor-optmization
branch
from
cde89c3 to
688a00a
Compare
parkera
approved these changes
Jun 20, 2018
|
@swift-ci test and merge |
1 similar comment
|
@swift-ci test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.