Fix NSString.boolValue not matching Darwin Foundation #1571
Conversation
|
@swift-ci please test |
otaviolima
force-pushed
the
match-darwing-nsstring-boolValue
branch
from
714d50d to
8d24063
Compare
|
I pushed again because previous implementation changed the tests in a wrong way. Instead of |
Foundation/NSString.swift
Outdated
| let _ = scanner.scanString("-") | ||
| } | ||
| // scan a single optional '+' or '-' character | ||
| let hasSignal = scanner.scanString("+") != nil || scanner.scanString("-") != nil | ||
| // scan any following zeroes |
There was a problem hiding this comment.
Looking at the Darwin implementation, it seems we check only the first character for t T y Y and return true. After that is when we do the scan for +/- and the digits.
There was a problem hiding this comment.
@otaviolima Can you switch this with the check in the return statement below? (i.e., check that first, then this.)
There was a problem hiding this comment.
You mean check in the same way @parkera explained it is in Darwin implementation?
There was a problem hiding this comment.
Yup, doing that right now. ^-^
Foundation/NSString.swift
Outdated
| let _ = scanner.scanString("-") | ||
| } | ||
| // scan a single optional '+' or '-' character | ||
| let hasSignal = scanner.scanString("+") != nil || scanner.scanString("-") != nil | ||
| // scan any following zeroes |
There was a problem hiding this comment.
@otaviolima Can you switch this with the check in the return statement below? (i.e., check that first, then this.)
otaviolima
force-pushed
the
match-darwing-nsstring-boolValue
branch
from
8d24063 to
bfe2a04
Compare
|
@swift-ci please test and merge |
There were some cases which were being evaluated to
truebut on Darwin/Objective-C they evaluate tofalse.