Re apply high sierra import #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@slavapestov is there a way we can actually trigger ubuntu 14 to be tested so that we dont have to revert this again? |
|
The changes to |
|
@spevans I can re-apply that in a subsequent PR |
|
@shahmishal do you know if there is a way to request a Ubuntu 14 test? |
|
We don't have anything at the moment other than merging, so we need to just put this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the revert of the High Sierra import and applies a guard against UMS_UK usage which only exists on ICU versions 55 and greater (which does not exist on Ubuntu 14)