Fix heap growth in Host.swift #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures that the `resolve` functionality only calculates addresses and names once, as appears to be originally intended. Furthermore, this mitigates a bug where addresses would be endlessly appended to the `addresses` array, causing long term unbounded heap growth.
|
@swift-ci please test |
|
@swizzlr PRs merged into |
|
@spevans Shall I open one against 4.0? I don't know if a new patch release is scheduled, but it seems like a small enough change to warrant inclusion. |
|
Can we add a test too? |
|
@ianpartridge Sure. |
swizzlr
changed the title
|
@swift-ci please test |
|
@ianpartridge added some tests, and realized the bug wasn't fixed for remote hosts, so fixed that too. Let me know if you want me to squash. |
|
@swift-ci please test |
|
@swift-ci please test and merge |
1 similar comment
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures that the
resolvefunctionality only calculatesaddresses and names once, as appears to be originally intended.
Furthermore, this mitigates a bug where addresses would be endlessly
appended to the
addressesarray, causing long term unbounded heapgrowth.
--
Am I correct in thinking this needs to go to master, then cherry-picked into 4.1 and 4.0? I couldn't find any docs in the contributing guidelines about branch structure.