Disable modular builds when compiling for >= c++20 modes #852
+118
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The clang compiler will implicitly enable the modules feature when in language mode c++20 or greater. This is for c++20 modules which strictly differs from clang modules, but are conflated at times like when the compiler evaluates `__has_feature(modules)`. Since the sdks cannot cleanly build in this mode, disable it by default but allow explicit overrides. rdar://156935289
cyndyishida
requested review from
aciidgh,
jakepetroules,
mhrawdon,
neonichu and
owenv
as code owners
|
@swift-ci please test |
owenv
approved these changes
Oct 8, 2025
|
Are the tests that are required to pass the ones triggered by |
|
This is the second time I've seen these this morning, I think it;s some kind of infra issue |
neonichu
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clang compiler will implicitly enable the modules feature when in language mode c++20 or greater. This is for c++20 modules, which strictly differ from clang modules, but are conflated at times like when the compiler evaluates
__has_feature(modules).Since the sdks cannot cleanly build in this mode, disable it by default but allow explicit overrides.
rdar://156935289